linux-kernel - Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+G9fYvOSRL5WaU1tYTxe4Y16h_kBbNsOibsH6Od5dc1tcmK6Q@mail.gmail.com>
Date:   Mon, 22 Jun 2020 11:48:35 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, inux-remoteproc@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Sibi Sankar <sibis@...eaurora.org>,
        Vinod Koul <vinod.koul@...aro.org>, agross@...nel.org,
        Ohad Ben Cohen <ohad@...ery.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-remoteproc@...r.kernel.org
Subject: Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error

On Sun, 21 Jun 2020 at 13:12, Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
>
> On Tue 16 Jun 23:56 PDT 2020, Naresh Kamboju wrote:
>
> > This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c
> >
> > Build error:
> >  ../drivers/remoteproc/qcom_q6v5_mss.c:
> >   In function ‘q6v5_mpss_init_image’:
> >  ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
> >   error: implicit declaration of function ‘kfree’;
> >   did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> >    772 |   kfree(metadata);
> >        |   ^~~~~
> >        |   vfree
> >
> > Signed-off-by: Naresh Kamboju <naresh.kamboju@...aro.org>
>
> Thanks for the patch Naresh, it looks correct but I've not seen this
> build error myself. Could you please let me know what you built to get
> this and if you have any suggestion on what caused it? (So we can add a
> Fixes: tag etc)

Thanks for the review.
This was an arm64 modules build failure on linux -next 20200616 tag.
This fix has already been taken care of by
Herbert Xu <herbert@...dor.apana.org.au> and got merged.
Fixes: f0187db056dc ("iov_iter: Move unnecessary inclusion of...")

ref:
https://lore.kernel.org/lkml/20200616010502.GA28834@gondor.apana.org.au/

- Naresh