linux-kernel - Re: arch/arm64/kernel/acpi.c:99:30: sparse: sparse: incorrect type in return expression (different address spaces)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeE=BrT5haBt8EL+ARGKah6D48XznTPf8RGseyXi=jRcw@mail.gmail.com>
Date:   Tue, 23 Jun 2020 00:55:43 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     kernel test robot <lkp@...el.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Tom Lendacky <thomas.lendacky@....com>
Cc:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: arch/arm64/kernel/acpi.c:99:30: sparse: sparse: incorrect type in
 return expression (different address spaces)

On Tue, Jun 23, 2020 at 12:42 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Mon, Jun 22, 2020 at 11:53 PM kernel test robot <lkp@...el.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   dd0d718152e4c65b173070d48ea9dfc06894c3e5
> > commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces
> > date:   4 days ago
> > config: arm64-randconfig-s031-20200622 (attached as .config)
> > compiler: aarch64-linux-gcc (GCC) 9.3.0
> > reproduce:
> >         # apt-get install sparse
> >         # sparse version: v0.6.2-rc1-18-g27caae40-dirty
> >         git checkout 670d0a4b10704667765f7d18f7592993d02783aa
> >         # save the attached .config to linux build tree
> >         make W=1 C=1 ARCH=arm64 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@...el.com>
> >
> >
> > sparse warnings: (new ones prefixed by >>)
> >
> > >> arch/arm64/kernel/acpi.c:99:30: sparse: sparse: incorrect type in return expression (different address spaces) @@     expected void [noderef] __iomem * @@     got void * @@
> > >> arch/arm64/kernel/acpi.c:99:30: sparse:     expected void [noderef] __iomem *
> >    arch/arm64/kernel/acpi.c:99:30: sparse:     got void *
> > >> arch/arm64/kernel/acpi.c:107:24: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void *addr @@     got void [noderef] __iomem *map @@
> >    arch/arm64/kernel/acpi.c:107:24: sparse:     expected void *addr
> > >> arch/arm64/kernel/acpi.c:107:24: sparse:     got void [noderef] __iomem *map
>
> ...
>
> > 6c9a58e84e59a2 Andy Shevchenko 2017-07-18   94  void __init __iomem *__acpi_map_table(unsigned long phys, unsigned long size)
> > 6c9a58e84e59a2 Andy Shevchenko 2017-07-18  102  void __init __acpi_unmap_table(void __iomem *map, unsigned long size)
>
> Seems like a new sparse fixed some sparse issues and reveals that the
> above was a mistake and should be reverted.

Either this patch
f7750a79568788473c5e8092ee58a52248f34329 x86, mpparse, x86/acpi,
x86/PCI, x86/dmi, SFI: Use memremap() for RAM mappings
shouldn't change to memremap(), or

void __iomem __ref *acpi_os_map_iomem(acpi_physical_address phys,
acpi_size size);
void __ref acpi_os_unmap_iomem(void __iomem *virt, acpi_size size);

Should be cleaned so they either not working with __iomem, or in
special cases force address space for above mentioned functions.

-- 
With Best Regards,
Andy Shevchenko