linux-kernel - Re: [PATCH net 1/3] net: ethtool: add missing string for NETIF_F_GSO_TUNNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200622215946.gbnx7mfavwvr4odz@lion.mk-sys.cz>
Date:   Mon, 22 Jun 2020 23:59:46 +0200
From:   Michal Kubecek <mkubecek@...e.cz>
To:     netdev@...r.kernel.org
Cc:     Alexander Lobakin <alobakin@...me>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>, Jiri Pirko <jiri@...lanox.com>,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Aya Levin <ayal@...lanox.com>,
        Tom Herbert <therbert@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 1/3] net: ethtool: add missing string for
 NETIF_F_GSO_TUNNEL_REMCSUM

On Fri, Jun 19, 2020 at 06:49:46PM +0000, Alexander Lobakin wrote:
> Commit e585f2363637 ("udp: Changes to udp_offload to support remote
> checksum offload") added new GSO type and a corresponding netdev
> feature, but missed Ethtool's 'netdev_features_strings' table.
> Give it a name so it will be exposed to userspace and become available
> for manual configuration.
> 
> Fixes: e585f2363637 ("udp: Changes to udp_offload to support remote
> checksum offload")
> Signed-off-by: Alexander Lobakin <alobakin@...me>

Reviewed-by: Michal Kubecek <mkubecek@...e.cz>

> ---
>  net/ethtool/common.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ethtool/common.c b/net/ethtool/common.c
> index 47f63526818e..aaecfc916a4d 100644
> --- a/net/ethtool/common.c
> +++ b/net/ethtool/common.c
> @@ -40,6 +40,7 @@ const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN] = {
>  	[NETIF_F_GSO_UDP_TUNNEL_BIT] =	 "tx-udp_tnl-segmentation",
>  	[NETIF_F_GSO_UDP_TUNNEL_CSUM_BIT] = "tx-udp_tnl-csum-segmentation",
>  	[NETIF_F_GSO_PARTIAL_BIT] =	 "tx-gso-partial",
> +	[NETIF_F_GSO_TUNNEL_REMCSUM_BIT] = "tx-tunnel-remcsum-segmentation",
>  	[NETIF_F_GSO_SCTP_BIT] =	 "tx-sctp-segmentation",
>  	[NETIF_F_GSO_ESP_BIT] =		 "tx-esp-segmentation",
>  	[NETIF_F_GSO_UDP_L4_BIT] =	 "tx-udp-segmentation",
> -- 
> 2.27.0
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)