linux-kernel - Re: mmotm 2020-06-20-21-36 uploaded (lkdtm/bugs.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLxGvw4NeBw3tDEnvL4USxgp--=vT1iXc6-tzAd_NkWCmUNFA@mail.gmail.com>
Date:   Tue, 23 Jun 2020 00:00:39 +0200
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Randy Dunlap <rd.dunlab@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mark Brown <broonie@...nel.org>, Michal Hocko <mhocko@...e.cz>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        linux-mm@...ck.org, LKML <linux-kernel@...r.kernel.org>,
        mm-commits@...r.kernel.org,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        linux-um <linux-um@...ts.infradead.org>
Subject: Re: mmotm 2020-06-20-21-36 uploaded (lkdtm/bugs.c)

On Mon, Jun 22, 2020 at 11:51 PM Kees Cook <keescook@...omium.org> wrote:
>
> On Mon, Jun 22, 2020 at 08:37:17AM -0700, Randy Dunlap wrote:
> > On 6/20/20 9:37 PM, akpm@...ux-foundation.org wrote:
> > > The mm-of-the-moment snapshot 2020-06-20-21-36 has been uploaded to
> > >
> > >    http://www.ozlabs.org/~akpm/mmotm/
> > >
> > > mmotm-readme.txt says
> > >
> > > README for mm-of-the-moment:
> > >
> > > http://www.ozlabs.org/~akpm/mmotm/
> > >
> > > This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
> > > more than once a week.
> >
> > drivers/misc/lkdtm/bugs.c has build errors when building UML for i386
> > (allmodconfig or allyesconfig):
> >
> >
> > In file included from ../drivers/misc/lkdtm/bugs.c:17:0:
> > ../arch/x86/um/asm/desc.h:7:0: warning: "LDT_empty" redefined
> >  #define LDT_empty(info) (\
> >
> > In file included from ../arch/um/include/asm/mmu.h:10:0,
> >                  from ../include/linux/mm_types.h:18,
> >                  from ../include/linux/sched/signal.h:13,
> >                  from ../drivers/misc/lkdtm/bugs.c:11:
> > ../arch/x86/um/asm/mm_context.h:65:0: note: this is the location of the previous definition
> >  #define LDT_empty(info) (_LDT_empty(info))
>
> The LKDTM test landed a while ago:
> b09511c253e5 ("lkdtm: Add a DOUBLE_FAULT crash type on x86")
>
> and nothing has touched arch/x86/um/asm/desc.h nor
> arch/x86/um/asm/mm_context.h in a while either.
>
> Regardless, it seems arch/x86/um/asm/desc.h is not needed any more?

True that, we can rip the file.

-- 
Thanks,
//richard