linux-kernel - Re: [PATCH net-next v1 2/5] hinic: add support to set and get irq coalesce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200622150756.3624dab2@kicinski-fedora-PC1C0HJN>
Date:   Mon, 22 Jun 2020 15:07:56 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Luo bin <luobin9@...wei.com>
Cc:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <luoxianjun@...wei.com>,
        <yin.yinshi@...wei.com>, <cloud.wangxiaoyun@...wei.com>
Subject: Re: [PATCH net-next v1 2/5] hinic: add support to set and get irq
 coalesce

On Sat, 20 Jun 2020 17:42:55 +0800 Luo bin wrote:
> @@ -1144,8 +1190,16 @@ static int nic_dev_init(struct pci_dev *pdev)
>  		goto err_reg_netdev;
>  	}
>  
> +	err = hinic_init_intr_coalesce(nic_dev);
> +	if (err) {
> +		netif_err(nic_dev, drv, netdev, "Failed to init_intr_coalesce\n");
> +		goto err_init_intr;
> +	}
> +
>  	return 0;
>  
> +err_init_intr:
> +	unregister_netdev(netdev);
>  err_reg_netdev:
>  err_set_features:
>  	hinic_hwdev_cb_unregister(nic_dev->hwdev,

A little suspicious - you should finish all init before device is
registered, once registered the interface can be immediately brought
up.