linux-kernel - Re: [v4 PATCH 0/3] Extend coredump functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200622222330.GN149351@builder.lan>
Date:   Mon, 22 Jun 2020 15:23:30 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Rishabh Bhatnagar <rishabhb@...eaurora.org>
Cc:     linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        tsoni@...eaurora.org, psodagud@...eaurora.org,
        sidgup@...eaurora.org, mathieu.poirier@...aro.org
Subject: Re: [v4 PATCH 0/3] Extend coredump functionality

On Wed 27 May 13:26 PDT 2020, Rishabh Bhatnagar wrote:

> This patch series moves the coredump functionality to a separate
> file and adds "inline" coredump feature. Inline coredump directly
> copies segments from device memory during coredump to userspace.
> This avoids extra memory usage at the cost of speed. Recovery is
> stalled until all data is read by userspace.
> 
> Changelog:
> 

Hi Rishabh,

This looks good to me, but it doesn't apply cleanly on linux-next. Can
you please take a look?

Regards,
Bjorn

> v4 -> v3:
> - Write a helper function to copy segment memory for every dump format
> - Change segment dump fn to add offset and size adn covert mss driver
> 
> v3 -> v2:
> - Move entire coredump functionality to remoteproc_coredump.c
> - Modify rproc_coredump to perform dump according to conf. set by userspace
> - Move the userspace configuration to debugfs from sysfs.
> - Keep the default coredump implementation as is
> 
> v2 -> v1:
> - Introduce new file for coredump.
> - Add userspace sysfs configuration for dump type.
> 
> Rishabh Bhatnagar (3):
>   remoteproc: Move coredump functionality to a new file
>   remoteproc: Add inline coredump functionality
>   remoteproc: Add coredump debugfs entry
> 
>  drivers/remoteproc/Makefile              |   1 +
>  drivers/remoteproc/qcom_q6v5_mss.c       |   9 +-
>  drivers/remoteproc/remoteproc_core.c     | 191 ------------------
>  drivers/remoteproc/remoteproc_coredump.c | 328 +++++++++++++++++++++++++++++++
>  drivers/remoteproc/remoteproc_debugfs.c  |  86 ++++++++
>  drivers/remoteproc/remoteproc_internal.h |   4 +
>  include/linux/remoteproc.h               |  21 +-
>  7 files changed, 443 insertions(+), 197 deletions(-)
>  create mode 100644 drivers/remoteproc/remoteproc_coredump.c
> 
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>