linux-kernel - Re: [PATCH net-next v9 2/5] net: phy: Add a helper to return the index for of the internal delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200622.154047.909380525276436349.davem@davemloft.net>
Date:   Mon, 22 Jun 2020 15:40:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dmurphy@...com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        robh@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v9 2/5] net: phy: Add a helper to return the
 index for of the internal delay

From: Dan Murphy <dmurphy@...com>
Date: Fri, 19 Jun 2020 11:18:10 -0500

> +s32 phy_get_internal_delay(struct phy_device *phydev, struct device *dev,
> +			   const int *delay_values, int size, bool is_rx)
> +{
> +	int i;
> +	s32 delay;

Please use reverse christmas tree ordering for local variables.