linux-kernel - Re: [PATCH] arch/x86: Check return value from a notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Jun 2020 08:50:08 +0800
From:   Bo YU <tsu.yubo@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     kernel-janitors@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>,
        Alexandre Chartre <alexandre.chartre@...cle.com>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Jann Horn <jannh@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] arch/x86: Check return value from a notify_die() call

On Sun, Jun 21, 2020 at 10:40 PM Markus Elfring <Markus.Elfring@....de> wrote:
>
> I propose to improve the previous patch subject.
>
>
> > This is detected by Coverity scan: #CID: 1464472(CHECKED_RETURN)
> >
> > FIXES: c94082656dac7(x86: Use enum instead of literals for trap values)
>
> Is the following tag specification more appropriate?
>
> Fixes: c94082656dac7 ("x86: Use enum instead of literals for trap values")
Your description looks like more appropriate, thank you.
But I want to receive suggestions from other reviewers also. So I will
send V2 patch as your point
once got confirmed. Sorry.
>
> Regards,
> Markus