linux-kernel - Re: [PATCH v1 1/2] mm: drop vm_total

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d388e8e-6888-85d3-3584-b20438d58d16@redhat.com>
Date:   Mon, 22 Jun 2020 09:03:10 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Mike Rapoport <rppt@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...e.com>,
        Huang Ying <ying.huang@...el.com>,
        Minchan Kim <minchan@...nel.org>,
        Wei Yang <richard.weiyang@...il.com>
Subject: Re: [PATCH v1 1/2] mm: drop vm_total_pages

On 21.06.20 16:46, Mike Rapoport wrote:
> On Fri, Jun 19, 2020 at 03:24:09PM +0200, David Hildenbrand wrote:
>> The global variable "vm_total_pages" is a relict from older days. There
>> is only a single user that reads the variable - build_all_zonelists() -
>> and the first thing it does is updating it. Use a local variable in
>> build_all_zonelists() instead and drop the local variable.
> 
> Nit:                                       ^ global

Indeed, @Andrew, can you fix this up?

Thanks!


-- 
Thanks,

David / dhildenb