linux-kernel - Re: [PATCH net v2] mptcp: drop sndr_key in mptcp_syn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c0f6f37-ede8-b341-f274-2b65b17dc141@tessares.net>
Date:   Mon, 22 Jun 2020 13:50:00 +0200
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Geliang Tang <geliangtang@...il.com>,
        Mat Martineau <mathew.j.martineau@...ux.intel.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] mptcp: drop sndr_key in mptcp_syn_options

Hi Geliang,

On 22/06/2020 13:45, Geliang Tang wrote:
> In RFC 8684, we don't need to send sndr_key in SYN package anymore, so drop

Please next time try to have max 72 chars per line in your commit message ;)

> it.
> 
> Fixes: cc7972ea1932 ("mptcp: parse and emit MP_CAPABLE option according to v1 spec")
> Signed-off-by: Geliang Tang <geliangtang@...il.com>

Thank you for this v2. It looks good to me!

Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net