linux-kernel - Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ae54858-0eb5-b3b8-c793-00a8b99c8aa5@pengutronix.de>
Date:   Mon, 22 Jun 2020 14:54:15 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        wg@...ndegger.com, kernel@...tin.sperl.org,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] Add Microchip MCP25XXFD CAN driver

On 6/22/20 2:43 PM, Kurt Van Dijck wrote:
> I get RX-0: FIFO overflows in listen-only mode (back-to-back burst of
> the single other node).

Single other node? Who's ACKing the CAN frames?

> The SPI peripheral does not use DMA :-(.

The SPI messages are quite small, so DMA wont help either. Getting rid of the
IRQ and polling for completion is the way to go.

> Do you have, by accident, some freescale SPI fixes lying around?

nope

> It's not the biggest problem on my side, but is proves the system not
> being guarded against load.

Do you have freq scaling activated?

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |