linux-kernel - Re: [PATCH v2] KVM: arm64: kvm_reset_vcpu() return code incorrect with SVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159283326373.239821.12024358556490900113.b4-ty@kernel.org>
Date:   Mon, 22 Jun 2020 14:41:27 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Alexandru Elisei <alexandru.elisei@....com>, kvm@...r.kernel.org,
        kvmarm@...ts.cs.columbia.edu, linux-arm-kernel@...ts.infradead.org,
        Catalin Marinas <catalin.marinas@....com>,
        Steven Price <steven.price@....com>,
        Will Deacon <will@...nel.org>
Cc:     james.morse@....com, suzuki.poulose@....com,
        julien.thierry.kdev@...il.com, linux-kernel@...r.kernel.org,
        Dave Martin <Dave.Martin@....com>
Subject: Re: [PATCH v2] KVM: arm64: kvm_reset_vcpu() return code incorrect with SVE

On Wed, 17 Jun 2020 11:54:56 +0100, Steven Price wrote:
> If SVE is enabled then 'ret' can be assigned the return value of
> kvm_vcpu_enable_sve() which may be 0 causing future "goto out" sites to
> erroneously return 0 on failure rather than -EINVAL as expected.
> 
> Remove the initialisation of 'ret' and make setting the return value
> explicit to avoid this situation in the future.

Applied to next, thanks!

[1/1] KVM: arm64: Fix kvm_reset_vcpu() return code being incorrect with SVE
      commit: 66b7e05dc0239c5817859f261098ba9cc2efbd2b

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.