linux-kernel - Re: [PATCH v4 1/4] spi: spi-fsl-dspi: Fix lockup if device is removed during SPI transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Jun 2020 15:59:53 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        linux-kernel@...r.kernel.org, Peng Ma <peng.ma@....com>,
        linux-spi@...r.kernel.org
Cc:     stable@...r.kernel.org, Wolfram Sang <wsa@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH v4 1/4] spi: spi-fsl-dspi: Fix lockup if device is removed during SPI transfer

On Mon, 22 Jun 2020 13:05:40 +0200, Krzysztof Kozlowski wrote:
> During device removal, the driver should unregister the SPI controller
> and stop the hardware.  Otherwise the dspi_transfer_one_message() could
> wait on completion infinitely.
> 
> Additionally, calling spi_unregister_controller() first in device
> removal reverse-matches the probe function, where SPI controller is
> registered at the end.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/4] spi: spi-fsl-dspi: Fix lockup if device is removed during SPI transfer
      commit: 7684580d45bd3d84ed9b453a4cadf7a9a5605a3f
[2/4] spi: spi-fsl-dspi: Fix lockup if device is shutdown during SPI transfer
      commit: 3c525b69e8c1a9a6944e976603c7a1a713e728f9
[3/4] spi: spi-fsl-dspi: Fix external abort on interrupt in resume or exit paths
      commit: 3d87b613d6a3c6f0980e877ab0895785a2dde581
[4/4] spi: spi-fsl-dspi: Initialize completion before possible interrupt
      commit: f148915f91fccd8c3df1b0bff7d1c8458cad3be5

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark