linux-kernel - Re: [PATCH v4 2/9] reset: Add Raspberry Pi 4 firmware reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4aaabc8ff39007a97a03f335c6a51313a2c59551.camel@suse.de>
Date:   Mon, 22 Jun 2020 17:08:09 +0200
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh@...nel.org>,
        Stefan Wahren <wahrenst@....net>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        USB <linux-usb@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        tim.gover@...pberrypi.org, linux-pci <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: Re: [PATCH v4 2/9] reset: Add Raspberry Pi 4 firmware reset
 controller

Hi Andy,

On Mon, 2020-06-22 at 17:42 +0300, Andy Shevchenko wrote:
> On Mon, Jun 22, 2020 at 5:26 PM Nicolas Saenz Julienne
> <nsaenzjulienne@...e.de> wrote:
> > Raspberry Pi 4's co-processor controls some of the board's HW
> > initialization process, but it's up to Linux to trigger it when
> > relevant. Introduce a reset controller capable of interfacing with
> > RPi4's co-processor that models these firmware initialization routines as
> > reset lines.
> 
> ...
> 
> > +       struct device_node *fw_node;
> 
> If you are going to use fwnode (as it should be), make sure the proper
> data type is in use, i.e. struct fwnode_handle.
> 
> Otherwise, if you want to be OF centric (I discourage this, don't know
> if RPi4 is ever going to run RHEL or other distros that require non-DT
> firmwares), don't name fw_node. It's confusing.

I agree it is confusing. I'll rename it. On the other hand, this is strictly DT
centric.

Regards,
Nicolas


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)