linux-kernel - Re: [PATCH v4 2/9] reset: Add Raspberry Pi 4 firmware reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Jun 2020 18:48:37 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh@...nel.org>,
        Stefan Wahren <wahrenst@....net>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        USB <linux-usb@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        tim.gover@...pberrypi.org, linux-pci <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: Re: [PATCH v4 2/9] reset: Add Raspberry Pi 4 firmware reset controller

On Mon, Jun 22, 2020 at 6:08 PM Nicolas Saenz Julienne
<nsaenzjulienne@...e.de> wrote:
> On Mon, 2020-06-22 at 17:42 +0300, Andy Shevchenko wrote:
> > On Mon, Jun 22, 2020 at 5:26 PM Nicolas Saenz Julienne
> > <nsaenzjulienne@...e.de> wrote:

...

> > > +       struct device_node *fw_node;
> >
> > If you are going to use fwnode (as it should be), make sure the proper
> > data type is in use, i.e. struct fwnode_handle.
> >
> > Otherwise, if you want to be OF centric (I discourage this, don't know
> > if RPi4 is ever going to run RHEL or other distros that require non-DT
> > firmwares), don't name fw_node. It's confusing.
>
> I agree it is confusing. I'll rename it. On the other hand, this is strictly DT
> centric.

AFAIU struct device_node *np is a usual pattern in OF-only world.

-- 
With Best Regards,
Andy Shevchenko