linux-kernel - [PATCH] input: i8042: remove redundant assignment to variable retval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20200622163144.107815-1-colin.king@canonical.com>
Date:   Mon, 22 Jun 2020 17:31:44 +0100
From:   Colin King <colin.king@...onical.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Rajat Jain <rajatja@...gle.com>,
        Stephen Boyd <swboyd@...omium.org>, linux-input@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] input: i8042: remove redundant assignment to variable retval

From: Colin Ian King <colin.king@...onical.com>

The variable retval is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/input/serio/i8042.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index 0dddf273afd9..cbaae80065e1 100644
--- a/drivers/input/serio/i8042.c
+++ b/drivers/input/serio/i8042.c
@@ -796,7 +796,7 @@ static int __init i8042_toggle_aux(bool on)
 
 static int __init i8042_check_aux(void)
 {
-	int retval = -1;
+	int retval;
 	bool irq_registered = false;
 	bool aux_loop_broken = false;
 	unsigned long flags;
-- 
2.27.0