linux-kernel - Re: [PATCH] xfs: Couple of typo fixes in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200622172912.GI11245@magnolia>
Date:   Mon, 22 Jun 2020 10:29:12 -0700
From:   "Darrick J. Wong" <darrick.wong@...cle.com>
To:     Keyur Patel <iamkeyur96@...il.com>
Cc:     allison.henderson@...cle.com, bfoster@...hat.com,
        chandanrlinux@...il.com, dchinner@...hat.com,
        linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org
Subject: Re: [PATCH] xfs: Couple of typo fixes in comments

On Sun, Jun 07, 2020 at 03:44:59AM -0400, Keyur Patel wrote:
> ./xfs/libxfs/xfs_inode_buf.c:56: unnecssary ==> unnecessary
> ./xfs/libxfs/xfs_inode_buf.c:59: behavour ==> behaviour
> ./xfs/libxfs/xfs_inode_buf.c:206: unitialized ==> uninitialized
> 
> Signed-off-by: Keyur Patel <iamkeyur96@...il.com>

Looks simple enough, though I bet this will have to be rebased against
5.8...

Reviewed-by: Darrick J. Wong <darrick.wong@...cle.com>

--D

> ---
>  fs/xfs/libxfs/xfs_inode_buf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_inode_buf.c b/fs/xfs/libxfs/xfs_inode_buf.c
> index 6f84ea85fdd8..5c93e8e6de74 100644
> --- a/fs/xfs/libxfs/xfs_inode_buf.c
> +++ b/fs/xfs/libxfs/xfs_inode_buf.c
> @@ -53,10 +53,10 @@ xfs_inobp_check(
>   * If the readahead buffer is invalid, we need to mark it with an error and
>   * clear the DONE status of the buffer so that a followup read will re-read it
>   * from disk. We don't report the error otherwise to avoid warnings during log
> - * recovery and we don't get unnecssary panics on debug kernels. We use EIO here
> + * recovery and we don't get unnecessary panics on debug kernels. We use EIO here
>   * because all we want to do is say readahead failed; there is no-one to report
>   * the error to, so this will distinguish it from a non-ra verifier failure.
> - * Changes to this readahead error behavour also need to be reflected in
> + * Changes to this readahead error behaviour also need to be reflected in
>   * xfs_dquot_buf_readahead_verify().
>   */
>  static void
> @@ -203,7 +203,7 @@ xfs_inode_from_disk(
>  	/*
>  	 * First get the permanent information that is needed to allocate an
>  	 * inode. If the inode is unused, mode is zero and we shouldn't mess
> -	 * with the unitialized part of it.
> +	 * with the uninitialized part of it.
>  	 */
>  	to->di_flushiter = be16_to_cpu(from->di_flushiter);
>  	inode->i_generation = be32_to_cpu(from->di_gen);
> -- 
> 2.26.2
>