linux-kernel - Re: [PATCH] drivers: base: power: mark 2 functions as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Jun 2020 18:34:41 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     len.brown@...el.com, pavel@....cz, gregkh@...uxfoundation.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drivers: base: power: mark 2 functions as __init to save some memory

On Sunday, June 21, 2020 10:18:54 AM CEST Christophe JAILLET wrote:
> 'early_resume_init()' and 'late_resume_init() 'are only called respectively
> via 'early_resume_init' and 'late_resume_init'.
> They can be marked as __init to save a few bytes of memory.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/base/power/trace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/base/power/trace.c b/drivers/base/power/trace.c
> index 977d27bd1a22..a97f33d0c59f 100644
> --- a/drivers/base/power/trace.c
> +++ b/drivers/base/power/trace.c
> @@ -265,14 +265,14 @@ static struct notifier_block pm_trace_nb = {
>  	.notifier_call = pm_trace_notify,
>  };
>  
> -static int early_resume_init(void)
> +static int __init early_resume_init(void)
>  {
>  	hash_value_early_read = read_magic_time();
>  	register_pm_notifier(&pm_trace_nb);
>  	return 0;
>  }
>  
> -static int late_resume_init(void)
> +static int __init late_resume_init(void)
>  {
>  	unsigned int val = hash_value_early_read;
>  	unsigned int user, file, dev;
> 

Applied as 5.8-rc material, thanks!