linux-kernel - Re: debugfs_create_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200623132119.5c4f2041@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 23 Jun 2020 13:21:19 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Ronald Tschalär <ronald@...ovation.ch>,
        Nicolai Stange <nicstange@...il.com>,
        David Rientjes <rientjes@...gle.com>,
        Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: debugfs_create_u32_array() memory leaks

On Mon, 22 Jun 2020 21:31:09 +0200 Greg Kroah-Hartman wrote:
> > Ah, I wasn't sure how to fix but since you say that create functions
> > shouldn't allocate memory seems like the fix will be to make callers
> > pass an equivalent of struct debugfs_blob_wrapper for u32.  
> 
> Sounds good.
> 
> > I'm happy to send a patch to that effect - I have a process question
> > tho - I need this change in net-next, should I sent the patch to you?
> > Can it still make it into 5.8 (debugfs -> Linus -> net -> net-next) or
> > perhaps can it go via net-next since there is no de facto bug in 5.8?  
> 
> I can take a fix now, and get it into 5.8 if that makes things easier
> for you.

Having thought about it - since I'm changing the prototype I'd have to
wait with my networking changes for the patch to land in net-next.

So I'll just send the debugfs fix with my other code to DaveM and CC
appropriately..