linux-kernel - [PATCH v2 0/6] kselftest: fix TAP output for skipped test and ksft_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Jun 2020 20:15:41 -0400
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     linux-kernel@...r.kernel.org
Cc:     shuah@...nel.org, linux-kselftest@...r.kernel.org
Subject: [PATCH v2 0/6] kselftest: fix TAP output for skipped test and ksft_set_plan misuse

This is v2 of the patch to fix TAP output for skipped tests.  I noticed
and fixed two other occurrences of "not ok ... # SKIP" which according
to the TAP specification should be marked as "ok ... # SKIP" instead.

Unfortunately, closer analysis showed ksft_exit_skip to be a badly
misused API.  It should be used when the remainder of the testcase
is being skipped, but TAP only supports this before the test plan
has been emitted (in which case you're supposed to print "1..0 # SKIP".

Therefore, in patch 1 I'm mostly trying to do something sensible,
printing "1..0 # SKIP" is possible or "ok ... # SKIP" if not (which is
no worse than what was doing before).  The remaining five patches
show what needs to be done in order to avoid ksft_exit_skip misuse;
while working on them I found other bugs that I've fixed at the same
time; see patch 2 for an example.

In the interest of full disclosure, I won't be able to do more cleanups
of ksft_exit_skip callers.  However, I have fixed all those that did
call ksft_set_plan() as those at least try to produce TAP output.

Paolo

Paolo Bonzini (6):
  kselftest: fix TAP output for skipped tests
  selftests: breakpoints: fix computation of test plan
  selftests: breakpoints: do not use ksft_exit_skip after ksft_set_plan
  selftests: pidfd: do not use ksft_exit_skip after ksft_set_plan
  selftests: sigaltstack: do not use ksft_exit_skip after ksft_set_plan
  selftests: sync_test: do not use ksft_exit_skip after ksft_set_plan

 .../breakpoints/step_after_suspend_test.c     | 53 +++++++++++--------
 tools/testing/selftests/kselftest.h           | 28 +++++++---
 tools/testing/selftests/kselftest/runner.sh   |  2 +-
 tools/testing/selftests/pidfd/pidfd_test.c    | 39 +++++++++++---
 tools/testing/selftests/sigaltstack/sas.c     |  4 +-
 tools/testing/selftests/sync/sync_test.c      |  2 +-
 6 files changed, 87 insertions(+), 41 deletions(-)

-- 
2.26.2