linux-kernel - Re: [PATCH net-next v9 2/5] net: phy: Add a helper to return the index for of the internal delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43e0247e-a62a-b34e-016f-c2e540591df2@ti.com>
Date:   Mon, 22 Jun 2020 20:19:00 -0500
From:   Dan Murphy <dmurphy@...com>
To:     David Miller <davem@...emloft.net>
CC:     <andrew@...n.ch>, <f.fainelli@...il.com>, <hkallweit1@...il.com>,
        <robh@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH net-next v9 2/5] net: phy: Add a helper to return the
 index for of the internal delay

David

On 6/22/20 5:40 PM, David Miller wrote:
> From: Dan Murphy <dmurphy@...com>
> Date: Fri, 19 Jun 2020 11:18:10 -0500
>
>> +s32 phy_get_internal_delay(struct phy_device *phydev, struct device *dev,
>> +			   const int *delay_values, int size, bool is_rx)
>> +{
>> +	int i;
>> +	s32 delay;
> Please use reverse christmas tree ordering for local variables.

OK.

Dan