linux-kernel - Re: [PATCH 0/2] tracing: Fix config dependency and trigger parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bdcdd6d10342005a8c773f4ffb882dabf398e5ac.camel@kernel.org>
Date:   Tue, 23 Jun 2020 16:03:48 -0500
From:   Tom Zanussi <zanussi@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] tracing: Fix config dependency and trigger parser

Hi Masami,

On Sat, 2020-06-20 at 12:45 +0900, Masami Hiramatsu wrote:
> Hi,
> 
> These are some fixes which I found recentry on ftrace.
> 
>  - Since the boot-time tracing synthetic event feature is decoupled
>    from trigger recenty, it should use CONFIG_SYNTH_EVENT.

Oops, yeah, I missed this one in the update, thanks for finding it.

>  - The parser of event trigger seems rejecting some redundant
>    spaces. But it is hard users to find the wrong point. Such
>    spaces should be accepted.
> 

Agreed, your patch makes things much better, thanks.

You can add my reviewed-by for both patches.

Reviewed-by: Tom Zanussi <zanussi@...nel.org>

Thanks,

Tom

> BTW, I also found the trigger parser accepts some inputs which
> may not correctly formatted, e.g.
> 
>  # echo "traceon 1" > events/ftrace/print/trigger
> 
> (from the document, it must be "traceon:1")
> But I think this does not decrease the usability.
> 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (2):
>       tracing/boot: Fix config dependency for synthedic event
>       tracing: Fix event trigger to accept redundant spaces
> 
> 
>  kernel/trace/trace_boot.c           |    2 +-
>  kernel/trace/trace_events_trigger.c |   21 +++++++++++++++++++--
>  2 files changed, 20 insertions(+), 3 deletions(-)
> 
> --
> Masami Hiramatsu (Linaro) <mhiramat@...nel.org>