linux-kernel - Re: [PATCH] scsi: lpfc: Avoid another null dereference in lpfc_sli4_hba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <470678bf-2e08-c75f-db14-7569cc4fe4c7@broadcom.com>
Date:   Tue, 23 Jun 2020 13:23:17 -0700
From:   James Smart <james.smart@...adcom.com>
To:     SeongJae Park <sjpark@...zon.com>, jsmart2021@...il.com,
        dick.kennedy@...adcom.com
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        SeongJae Park <sjpark@...zon.de>
Subject: Re: [PATCH] scsi: lpfc: Avoid another null dereference in
 lpfc_sli4_hba_unset()



On 6/23/2020 1:41 AM, SeongJae Park wrote:
> From: SeongJae Park <sjpark@...zon.de>
>
> Commit cdb42becdd40 ("scsi: lpfc: Replace io_channels for nvme and fcp
> with general hdw_queues per cpu") has introduced static checker warnings
> for potential null dereferences in 'lpfc_sli4_hba_unset()' and
> commit 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning in
> lpfc_sli4_hba_unset") has tried to fix it.  However, yet another
> potential null dereference is remaining.  This commit fixes it.
>
> This bug was discovered and resolved using Coverity Static Analysis
> Security Testing (SAST) by Synopsys, Inc.
>
> Fixes: 1ffdd2c0440d ("scsi: lpfc: resolve static checker warning inlpfc_sli4_hba_unset")
> Fixes: cdb42becdd40 ("scsi: lpfc: Replace io_channels for nvme and fcp with general hdw_queues per cpu")
> Signed-off-by: SeongJae Park <sjpark@...zon.de>
> ---
>   drivers/scsi/lpfc/lpfc_init.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index 69a5249e007a..6637f84a3d1b 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -11878,7 +11878,8 @@ lpfc_sli4_hba_unset(struct lpfc_hba *phba)
>   	lpfc_sli4_xri_exchange_busy_wait(phba);
>   
>   	/* per-phba callback de-registration for hotplug event */
> -	lpfc_cpuhp_remove(phba);
> +	if (phba->pport)
> +		lpfc_cpuhp_remove(phba);
>   
>   	/* Disable PCI subsystem interrupt */
>   	lpfc_sli4_disable_intr(phba);

Reviewed-by: James Smart <james.smart@...adcom.com>

-- james