linux-kernel - RE: [PATCH] mailbox: imx: Mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR04MB4966C312C40364B5BCA18C8780940@AM6PR04MB4966.eurprd04.prod.outlook.com>
Date:   Tue, 23 Jun 2020 02:14:05 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Jassi Brar <jassisinghbrar@...il.com>
CC:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Anson Huang <anson.huang@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH] mailbox: imx: Mark PM functions as __maybe_unused

> From: Nathan Chancellor <natechancellor@...il.com>
> Sent: Tuesday, June 23, 2020 9:04 AM
> 
> When CONFIG_PM and CONFIG_PM_SLEEP are unset, the following warnings
> occur:
> 
> drivers/mailbox/imx-mailbox.c:638:12: warning: 'imx_mu_runtime_resume'
> defined but not used [-Wunused-function]
>   638 | static int imx_mu_runtime_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~~
> drivers/mailbox/imx-mailbox.c:629:12: warning: 'imx_mu_runtime_suspend'
> defined but not used [-Wunused-function]
>   629 | static int imx_mu_runtime_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~~~
> drivers/mailbox/imx-mailbox.c:611:12: warning: 'imx_mu_resume_noirq'
> defined but not used [-Wunused-function]
>   611 | static int imx_mu_resume_noirq(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~
> drivers/mailbox/imx-mailbox.c:601:12: warning: 'imx_mu_suspend_noirq'
> defined but not used [-Wunused-function]
>   601 | static int imx_mu_suspend_noirq(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~
> 
> Mark these functions as __maybe_unused, which is the standard procedure for
> PM functions.
> 
> Fixes: bb2b2624dbe2 ("mailbox: imx: Add runtime PM callback to handle MU
> clocks")
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Thanks for catching this.

Reviewed-by: Dong Aisheng <aisheng.dong@....com>

Regards
Aisheng