linux-kernel - Re: [PATCH net-next v10 2/5] net: phy: Add a helper to return the index for of the internal delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200623.150243.580522101088235218.davem@davemloft.net>
Date:   Tue, 23 Jun 2020 15:02:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dmurphy@...com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        robh@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v10 2/5] net: phy: Add a helper to return the
 index for of the internal delay

From: Dan Murphy <dmurphy@...com>
Date: Tue, 23 Jun 2020 08:48:33 -0500

> diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
> index 29ef4456ac25..96f242eed058 100644
> --- a/drivers/net/phy/phy_device.c
> +++ b/drivers/net/phy/phy_device.c
 ...
> +static inline int phy_get_int_delay_property(struct device *dev,
> +					     const char *name)

Please do not use inline in foo.c files, thank you.