linux-kernel - Re: [PATCH net-next] bonding/xfrm: use real_dev instead of slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200623.152009.1181630031177940079.davem@davemloft.net>
Date:   Tue, 23 Jun 2020 15:20:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jarod@...hat.com
Cc:     linux-kernel@...r.kernel.org, borisp@...lanox.com,
        saeedm@...lanox.com, leon@...nel.org, j.vosburgh@...il.com,
        vfalico@...il.com, andy@...yhouse.net, jeffrey.t.kirsher@...el.com,
        kuba@...nel.org, steffen.klassert@...unet.com,
        herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bonding/xfrm: use real_dev instead of
 slave_dev

From: Jarod Wilson <jarod@...hat.com>
Date: Tue, 23 Jun 2020 16:40:01 -0400

> Rather than requiring every hw crypto capable NIC driver to do a check for
> slave_dev being set, set real_dev in the xfrm layer and xso init time, and
> then override it in the bonding driver as needed. Then NIC drivers can
> always use real_dev, and at the same time, we eliminate the use of a
> variable name that probably shouldn't have been used in the first place,
> particularly given recent current events.
> 
> CC: Boris Pismenny <borisp@...lanox.com>
> CC: Saeed Mahameed <saeedm@...lanox.com>
> CC: Leon Romanovsky <leon@...nel.org>
> CC: Jay Vosburgh <j.vosburgh@...il.com>
> CC: Veaceslav Falico <vfalico@...il.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> CC: "David S. Miller" <davem@...emloft.net>
> CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> CC: Jakub Kicinski <kuba@...nel.org>
> CC: Steffen Klassert <steffen.klassert@...unet.com>
> CC: Herbert Xu <herbert@...dor.apana.org.au>
> CC: netdev@...r.kernel.org
> Suggested-by: Saeed Mahameed <saeedm@...lanox.com>
> Signed-off-by: Jarod Wilson <jarod@...hat.com>

Yes this is much nicer.

Applied, thank you.