linux-kernel - RE: [PATCH 2/3] arm64: dts: imx8qxp: add i2c aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB6PR0402MB2760A7116D8743792570BEE088940@DB6PR0402MB2760.eurprd04.prod.outlook.com>
Date:   Tue, 23 Jun 2020 07:06:51 +0000
From:   Peng Fan <peng.fan@....com>
To:     Shawn Guo <shawnguo@...nel.org>
CC:     Fabio Estevam <fabio.estevam@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Aisheng Dong <aisheng.dong@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Leonard Crestez <leonard.crestez@....com>,
        Daniel Baluta <daniel.baluta@....com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH 2/3] arm64: dts: imx8qxp: add i2c aliases

Hi Shawn,

> Subject: Re: [PATCH 2/3] arm64: dts: imx8qxp: add i2c aliases
> 
> On Mon, Jun 01, 2020 at 10:06:19AM +0800, peng.fan@....com wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > The devices could be enumerated properly with aliases.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > index 33363c127478..8ce997110cd6 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > @@ -19,6 +19,10 @@
> >  	#size-cells = <2>;
> >
> >  	aliases {
> > +		i2c0 = &adma_i2c0;
> > +		i2c1 = &adma_i2c1;
> > +		i2c2 = &adma_i2c2;
> > +		i2c3 = &adma_i2c3;
> 
> Had a second look.  It breaks alphabetical order.  So dropped the series.

V2 has this addressed.
https://patchwork.kernel.org/cover/11619867/

Thanks,
Peng.

> 
> Shawn
> 
> >  		gpio0 = &lsio_gpio0;
> >  		gpio1 = &lsio_gpio1;
> >  		gpio2 = &lsio_gpio2;
> > --
> > 2.16.4
> >