linux-kernel - Re: [PATCH v3 3/3] ASoC: ti: Add custom machine driver for j721e EVM (CPB and IVI)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c255c3c-8c9c-9200-962f-69de9a1f861c@ti.com>
Date:   Tue, 23 Jun 2020 12:28:57 +0300
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     Mark Brown <broonie@...nel.org>
CC:     <lgirdwood@...il.com>, <robh+dt@...nel.org>,
        <alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/3] ASoC: ti: Add custom machine driver for j721e EVM
 (CPB and IVI)



On 12/06/2020 15.27, Mark Brown wrote:
> On Fri, Jun 12, 2020 at 12:27:17PM +0300, Peter Ujfalusi wrote:
> 
>>> +	if (IS_ERR(clocks->target)) {
>>> +		ret = PTR_ERR(clocks->target);
>>> +		if (ret != -EPROBE_DEFER)
>>> +			dev_err(dev, "failed to acquire %s': %d\n",
> 
>> Looks like I have extra "'" in the prints...
> 
> Apart from the issues you pointed out yourself this all looks reasonable
> to me.

Thanks Mark,
I'll wait for Rob on the binding doc side before I send the updated v4.

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki