lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Jun 2020 12:47:11 +0300 From: Stanimir Varbanov <stanimir.varbanov@...aro.org> To: Dinghao Liu <dinghao.liu@....edu.cn>, kjlu@....edu Cc: Stanimir Varbanov <stanimir.varbanov@...aro.org>, Andy Gross <agross@...nel.org>, Bjorn Andersson <bjorn.andersson@...aro.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] media: venus: venc: Fix runtime PM imbalance in venc_open Hi Dinghao, Thanks for the patch! On 5/24/20 7:31 AM, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn> > --- > drivers/media/platform/qcom/venus/venc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Acked-by: Stanimir Varbanov <stanimir.varbanov@...aro.org> > > diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c > index 9981a2a27c90..eefcfbb8f211 100644 > --- a/drivers/media/platform/qcom/venus/venc.c > +++ b/drivers/media/platform/qcom/venus/venc.c > @@ -1169,7 +1169,7 @@ static int venc_open(struct file *file) > > ret = pm_runtime_get_sync(core->dev_enc); > if (ret < 0) > - goto err_free_inst; > + goto err_put_sync; > > ret = venc_ctrl_init(inst); > if (ret) > @@ -1214,7 +1214,6 @@ static int venc_open(struct file *file) > venc_ctrl_deinit(inst); > err_put_sync: > pm_runtime_put_sync(core->dev_enc); > -err_free_inst: > kfree(inst); > return ret; > } > -- regards, Stan
Powered by blists - more mailing lists