linux-kernel - Re: [PATCH v3] acpi: Extend TPM2 ACPI table with missing log fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d032b3c-650b-b806-3d97-2921341b7f0e@linux.ibm.com>
Date:   Tue, 23 Jun 2020 07:27:42 -0400
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        linux-integrity@...r.kernel.org,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-security-module@...r.kernel.org
Subject: Re: [PATCH v3] acpi: Extend TPM2 ACPI table with missing log fields

On 6/22/20 8:56 PM, Jarkko Sakkinen wrote:
> On Fri, Jun 19, 2020 at 11:14:20AM -0400, Stefan Berger wrote:
>> On 4/2/20 3:21 PM, Jarkko Sakkinen wrote:
>>> On Wed, Apr 01, 2020 at 11:05:36AM +0200, Rafael J. Wysocki wrote:
>>>> On Wed, Apr 1, 2020 at 10:37 AM Jarkko Sakkinen
>>>> <jarkko.sakkinen@...ux.intel.com> wrote:
>>>>> On Tue, Mar 31, 2020 at 05:49:49PM -0400, Stefan Berger wrote:
>>>>>> From: Stefan Berger <stefanb@...ux.ibm.com>
>>>>>>
>>>>>> Recent extensions of the TPM2 ACPI table added 3 more fields
>>>>>> including 12 bytes of start method specific parameters and Log Area
>>>>>> Minimum Length (u32) and Log Area Start Address (u64). So, we extend
>>>>>> the existing structure with these fields to allow non-UEFI systems
>>>>>> to access the TPM2's log.
>>>>>>
>>>>>> The specification that has the new fields is the following:
>>>>>>     TCG ACPI Specification
>>>>>>     Family "1.2" and "2.0"
>>>>>>     Version 1.2, Revision 8
>>>>>>
>>>>>> Adapt all existing table size calculations to use
>>>>>> offsetof(struct acpi_table_tpm2, start_method_specific)
>>>>>> [where start_method_specific is a newly added field]
>>>>>> rather than sizeof(struct acpi_table_tpm2) so that the addition
>>>>>> of the new fields does not affect current systems that may not
>>>>>> have them.
>>>>>>
>>>>>> Signed-off-by: Stefan Berger <stefanb@...ux.ibm.com>
>>>>>> Cc: linux-acpi@...r.kernel.org
>>>>> I think I'm cool with this but needs an ack from ACPI maintainer.
>>>>>
>>>>> Rafael, given that this not an intrusive change in any possible means,
>>>>> can I pick this patch and put it to my next pull request?
>>>> Yes, please.
>>>>
>>>> Thanks!
>>> Great, thanks Rafael.
>>>
>>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
>>>
>>> Do you mind if I add your ack to the commit?
>>
>> Any chance to get v4 applied?
> You should split the actbl3.h change to a separate patch and add 'Cc:'
> tag to Rafael to the commit message.

I did this in one patch because it seems like a mistake to extend the 
structure and not modify the size checks.

   Stefan

>
> /Jarkko