linux-kernel - Re: [PATCH] dt-bindings: bus: uniphier-system-bus: fix warning in example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Jun 2020 20:31:52 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        DTML <devicetree@...r.kernel.org>
Cc:     linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: bus: uniphier-system-bus: fix warning in example

On Tue, Jun 23, 2020 at 3:29 PM Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
>
> Since commit e69f5dc623f9 ("dt-bindings: serial: Convert 8250 to
> json-schema"), the schema for "ns16550a" is checked.
>
> 'make dt_binding_check' emits the following warning:
>
>   uart@5,00200000: $nodename:0: 'uart@5,00200000' does not match '^serial(@[0-9a-f,]+)*$'
>
> Rename the node to follow the pattern defined in
> Documentation/devicetree/bindings/serial/serial.yaml
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
>
>  .../devicetree/bindings/bus/socionext,uniphier-system-bus.yaml  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml b/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml
> index c4c9119e4a20..9fa4f891fa00 100644
> --- a/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml
> +++ b/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml
> @@ -87,7 +87,7 @@ examples:
>              phy-mode = "mii";
>          };
>
> -        uart@5,00200000 {
> +        serial@5,00200000 {


I think '5,200000' is a better unit name.

Will send v2.



>              compatible = "ns16550a";
>              reg = <5 0x00200000 0x20>;
>              interrupts = <0 49 4>;
> --
> 2.25.1
>


-- 
Best Regards
Masahiro Yamada