linux-kernel - drivers/net/ethernet/amazon/ena/ena_netdev.c:160:3: note: in expansion of macro 'xchg'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202006250038.YkcUCGFA%lkp@intel.com>
Date:   Thu, 25 Jun 2020 00:47:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sameeh Jubran <sameehj@...zon.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: drivers/net/ethernet/amazon/ena/ena_netdev.c:160:3: note: in
 expansion of macro 'xchg'

Hi Sameeh,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3e08a95294a4fb3702bb3d35ed08028433c37fe6
commit: 838c93dc5449e5d6378bae117b0a65a122cf7361 net: ena: implement XDP drop support
date:   7 months ago
config: ia64-randconfig-r013-20200624 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 838c93dc5449e5d6378bae117b0a65a122cf7361
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/amazon/ena/ena_netdev.c:150:6: warning: no previous prototype for 'ena_xdp_exchange_program_rx_in_range' [-Wmissing-prototypes]
     150 | void ena_xdp_exchange_program_rx_in_range(struct ena_adapter *adapter,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from arch/ia64/include/uapi/asm/intrinsics.h:22,
                    from arch/ia64/include/asm/intrinsics.h:11,
                    from arch/ia64/include/asm/bitops.h:19,
                    from include/linux/bitops.h:26,
                    from include/linux/bitmap.h:8,
                    from include/linux/ethtool.h:16,
                    from drivers/net/ethernet/amazon/ena/ena_netdev.c:38:
   drivers/net/ethernet/amazon/ena/ena_netdev.c: In function 'ena_xdp_exchange_program_rx_in_range':
   arch/ia64/include/uapi/asm/cmpxchg.h:57:2: warning: value computed is not used [-Wunused-value]
      57 | ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr))))
         | ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/amazon/ena/ena_netdev.c:160:3: note: in expansion of macro 'xchg'
     160 |   xchg(&rx_ring->xdp_bpf_prog, prog);
         |   ^~~~
   drivers/net/ethernet/amazon/ena/ena_netdev.c: At top level:
   drivers/net/ethernet/amazon/ena/ena_netdev.c:168:6: warning: no previous prototype for 'ena_xdp_exchange_program' [-Wmissing-prototypes]
     168 | void ena_xdp_exchange_program(struct ena_adapter *adapter,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/amazon/ena/ena_netdev.c:1154:5: warning: no previous prototype for 'ena_xdp_handle_buff' [-Wmissing-prototypes]
    1154 | int ena_xdp_handle_buff(struct ena_ring *rx_ring, struct xdp_buff *xdp)
         |     ^~~~~~~~~~~~~~~~~~~

vim +/xchg +160 drivers/net/ethernet/amazon/ena/ena_netdev.c

   149	
   150	void ena_xdp_exchange_program_rx_in_range(struct ena_adapter *adapter,
   151						  struct bpf_prog *prog,
   152						  int first,
   153						  int count)
   154	{
   155		struct ena_ring *rx_ring;
   156		int i = 0;
   157	
   158		for (i = first; i < count; i++) {
   159			rx_ring = &adapter->rx_ring[i];
 > 160			xchg(&rx_ring->xdp_bpf_prog, prog);
   161			if (prog)
   162				rx_ring->rx_headroom = XDP_PACKET_HEADROOM;
   163			else
   164				rx_ring->rx_headroom = 0;
   165		}
   166	}
   167	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33869 bytes)