linux-kernel - [PATCH] mm: filemap: clear idle flag for writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1593020612-13051-1-git-send-email-yang.shi@linux.alibaba.com>
Date:   Thu, 25 Jun 2020 01:43:32 +0800
From:   Yang Shi <yang.shi@...ux.alibaba.com>
To:     hannes@...xchg.org, riel@...riel.com, shakeelb@...gle.com,
        gavin.dg@...ux.alibaba.com, akpm@...ux-foundation.org
Cc:     yang.shi@...ux.alibaba.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] mm: filemap: clear idle flag for writes

Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap:
only do access activations on reads"), mark_page_accessed() is called
for reads only.  But the idle flag is cleared by mark_page_accessed() so
the idle flag won't get cleared if the page is write accessed only.

Basically idle page tracking is used to estimate workingset size of
workload, noticeable size of workingset might be missed if the idle flag
is not maintained correctly.

It seems good enough to just clear idle flag for write operations.

Fixes: bbddabe2e436 ("mm: filemap: only do access activations on reads")
Cc: Johannes Weiner <hannes@...xchg.org>
Cc: Rik van Riel <riel@...riel.com>
Cc: Shakeel Butt <shakeelb@...gle.com>
Reported-by: Gang Deng <gavin.dg@...ux.alibaba.com>
Signed-off-by: Yang Shi <yang.shi@...ux.alibaba.com>
---
 mm/filemap.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/mm/filemap.c b/mm/filemap.c
index f0ae9a6..0589aef 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -41,6 +41,7 @@
 #include <linux/delayacct.h>
 #include <linux/psi.h>
 #include <linux/ramfs.h>
+#include <linux/page_idle.h>
 #include "internal.h"
 
 #define CREATE_TRACE_POINTS
@@ -1630,6 +1631,11 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index,
 
 	if (fgp_flags & FGP_ACCESSED)
 		mark_page_accessed(page);
+	else if (fgp_flags & FGP_WRITE) {
+		/* Clear idle flag for buffer write */
+		if (page_is_idle(page))
+			clear_page_idle(page);
+	}
 
 no_page:
 	if (!page && (fgp_flags & FGP_CREAT)) {
-- 
1.8.3.1