linux-kernel - Re: [PATCH] net: qrtr: free flow in __qrtr_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Jun 2020 20:26:29 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     cjhuang@...eaurora.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        ath11k@...ts.infradead.org
Subject: Re: [PATCH] net: qrtr: free flow in __qrtr_node_release

From: Carl Huang <cjhuang@...eaurora.org>
Date: Tue, 23 Jun 2020 11:22:03 +0800

> @@ -168,6 +168,7 @@ static void __qrtr_node_release(struct kref *kref)
>  	struct radix_tree_iter iter;
>  	unsigned long flags;
>  	void __rcu **slot;
> +	struct qrtr_tx_flow *flow;

Please retain the reverse christmas tree ordering of local variables here.

Thanks.