linux-kernel - Re: [PATCH][next] net: ipv6: Use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200623.202726.850834635899072423.davem@davemloft.net>
Date:   Tue, 23 Jun 2020 20:27:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gustavoars@...nel.org
Cc:     kuba@...nel.org, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        gustavo@...eddedor.com
Subject: Re: [PATCH][next] net: ipv6: Use struct_size() helper and kcalloc()

From: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Date: Mon, 22 Jun 2020 18:07:41 -0500

> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes. Also, remove unnecessary
> function ipv6_rpl_srh_alloc_size() and replace kzalloc() with kcalloc(),
> which has a 2-factor argument form for multiplication.
> 
> This code was detected with the help of Coccinelle and, audited and
> fixed manually.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Applied.