linux-kernel - Re: [PATCH] Bluetooth: Don't restart scanning if paused

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <EAEF89F3-8F6B-49AE-95B4-E6A961C6474D@holtmann.org>
Date:   Wed, 24 Jun 2020 21:40:03 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
Cc:     BlueZ <linux-bluetooth@...r.kernel.org>,
        Alain Michaud <alainm@...omium.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Johan Hedberg <johan.hedberg@...il.com>,
        netdev <netdev@...r.kernel.org>,
        kernel list <linux-kernel@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH] Bluetooth: Don't restart scanning if paused

Hi Abhishek,

> When restarting LE scanning, check if it's currently paused before
> enabling passive scanning.
> 
> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
> ---
> When running suspend stress tests on Chromebooks, we discovered
> instances where the Chromebook didn't enter the deepest idle states
> (i.e. S0ix). After some debugging, we found that passive scanning was
> being enabled AFTER the suspend notifier had run (and disabled all
> scanning).
> 
> For this fix, I simply looked at all the places where we call
> HCI_OP_LE_SET_SCAN_ENABLE and added a guard clause for suspend. With
> this fix, we were able to get through 100+ iterations of the suspend
> stress test without any problems entering S0ix.
> 
> 
> net/bluetooth/hci_request.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel