linux-kernel - Re: [PATCH 2/2] net: ethernet: mvneta: Add back interface mode validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200624.144837.358793393121356729.davem@davemloft.net>
Date:   Wed, 24 Jun 2020 14:48:37 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     s.hauer@...gutronix.de
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, thomas.petazzoni@...tlin.com,
        kernel@...gutronix.de, linux@...linux.org.uk
Subject: Re: [PATCH 2/2] net: ethernet: mvneta: Add back interface mode
 validation

From: Sascha Hauer <s.hauer@...gutronix.de>
Date: Wed, 24 Jun 2020 09:00:45 +0200

> When writing the serdes configuration register was moved to
> mvneta_config_interface() the whole code block was removed from
> mvneta_port_power_up() in the assumption that its only purpose was to
> write the serdes configuration register. As mentioned by Russell King
> its purpose was also to check for valid interface modes early so that
> later in the driver we do not have to care for unexpected interface
> modes.
> Add back the test to let the driver bail out early on unhandled
> interface modes.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>

Applied.

Please submit a proper patch series next time, with a header [PATCH 0/N]
posting.  Thank you.