linux-kernel - Re: [PATCH] firewire: nosy: Fix the amount of memory deallocated by some 'pci_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Jun 2020 06:35:49 +0800
From:   kernel test robot <lkp@...el.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        stefanr@...6.in-berlin.de, krh@...planet.net, hch@...radead.org
Cc:     kbuild-all@...ts.01.org, linux1394-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH] firewire: nosy: Fix the amount of memory deallocated by
 some 'pci_free_consistent' calls

Hi Christophe,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on firewire/for-next]
[also build test ERROR on v5.8-rc2 next-20200624]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christophe-JAILLET/firewire-nosy-Fix-the-amount-of-memory-deallocated-by-some-pci_free_consistent-calls/20200625-032633
base:   https://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git for-next
config: x86_64-randconfig-m001-20200624 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/firewire/nosy.c: In function 'remove_card':
>> drivers/firewire/nosy.c:513:40: error: 'RCV_BUFFER_SIZE' undeclared (first use in this function); did you mean 'UEVENT_BUFFER_SIZE'?
     513 |  pci_free_consistent(lynx->pci_device, RCV_BUFFER_SIZE,
         |                                        ^~~~~~~~~~~~~~~
         |                                        UEVENT_BUFFER_SIZE
   drivers/firewire/nosy.c:513:40: note: each undeclared identifier is reported only once for each function it appears in

vim +513 drivers/firewire/nosy.c

   489	
   490	static void
   491	remove_card(struct pci_dev *dev)
   492	{
   493		struct pcilynx *lynx = pci_get_drvdata(dev);
   494		struct client *client;
   495	
   496		mutex_lock(&card_mutex);
   497		list_del_init(&lynx->link);
   498		misc_deregister(&lynx->misc);
   499		mutex_unlock(&card_mutex);
   500	
   501		reg_write(lynx, PCI_INT_ENABLE, 0);
   502		free_irq(lynx->pci_device->irq, lynx);
   503	
   504		spin_lock_irq(&lynx->client_list_lock);
   505		list_for_each_entry(client, &lynx->client_list, link)
   506			wake_up_interruptible(&client->buffer.wait);
   507		spin_unlock_irq(&lynx->client_list_lock);
   508	
   509		pci_free_consistent(lynx->pci_device, sizeof(struct pcl),
   510				    lynx->rcv_start_pcl, lynx->rcv_start_pcl_bus);
   511		pci_free_consistent(lynx->pci_device, sizeof(struct pcl),
   512				    lynx->rcv_pcl, lynx->rcv_pcl_bus);
 > 513		pci_free_consistent(lynx->pci_device, RCV_BUFFER_SIZE,
   514				    lynx->rcv_buffer, lynx->rcv_buffer_bus);
   515	
   516		iounmap(lynx->registers);
   517		pci_disable_device(dev);
   518		lynx_put(lynx);
   519	}
   520	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (31861 bytes)