linux-kernel - Re: [PATCH 4.19 066/206] soundwire: slave: dont init debugfs on device registration error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Jun 2020 20:55:28 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Guennadi Liakhovetski <guennadi.liakhovetski@...ux.intel.com>,
        Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH 4.19 066/206] soundwire: slave: dont init debugfs on
 device registration error

On Tue, Jun 23, 2020 at 11:11:03PM +0200, Pavel Machek wrote:
>Hi!
>
>> [ Upstream commit 8893ab5e8ee5d7c12e0fc1dca4a309475064473d ]
>>
>> The error handling flow seems incorrect, there is no reason to try and
>> add debugfs support if the device registration did not
>> succeed. Return on error.
>
>> +++ b/drivers/soundwire/slave.c
>> @@ -55,6 +55,8 @@ static int sdw_slave_add(struct sdw_bus *bus,
>>  		list_del(&slave->node);
>>  		mutex_unlock(&bus->bus_lock);
>>  		put_device(&slave->dev);
>> +
>> +		return ret;
>>  	}
>>
>>  	return ret;
>
>Mainline is significantly different here; this patch does not make
>sense in v4.19 -- as it does not do anything.

I've dropped it from 4.19, thanks!

-- 
Thanks,
Sasha