linux-kernel - Re: [PATCH v3 2/2] USB: serial: cp210x: Proper RTS control when buffers fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200624070910.GA1557212@kroah.com>
Date:   Wed, 24 Jun 2020 09:09:10 +0200
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Phu Luu <Phu.Luu@...abs.com>
Cc:     "johan@...nel.org" <johan@...nel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Brant Merryman <Brant.Merryman@...abs.com>,
        Richard Hendricks <Richard.Hendricks@...abs.com>
Subject: Re: [PATCH v3 2/2] USB: serial: cp210x: Proper RTS control when
 buffers fill

On Wed, Jun 24, 2020 at 07:03:04AM +0000, Phu Luu wrote:
> CP210x hardware disables auto-RTS but leaves auto-CTS when
> in hardware flow control mode and UART on cp210x hardware
> is disabled. This allows data to flow out, but new data
> will not come into the port. When re-opening the port, if
> auto-CTS is enabled on the cp210x, then auto-RTS must be
> re-enabled in the driver.
> 
> Signed-off-by: Phu Luu <phu.luu@...abs.com>
> Signed-off-by: Brant Merryman <brant.merryman@...abs.com>
> ---
> 06/09/2020: Patch v3 2/2 Modified based on feedback from Johan Hovold <johan@...nel.org>
> 12/18/2019: Patch v2 Broken into two patches and modified based on feedback from Johan Hovold <johan@...nel.org>
> 12/09/2019: Initial submission of patch "Proper RTS control when buffers fill"
> 
> drivers/usb/serial/cp210x.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index bcceb4ad8be0..091441b1c5b9 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -917,6 +917,7 @@ static void cp210x_get_termios_port(struct usb_serial_port *port,
>                u32 baud;
>                u16 bits;
>                u32 ctl_hs;
> +             u32 flow_repl;
>                 cp210x_read_u32_reg(port, CP210X_GET_BAUDRATE, &baud);
> @@ -1017,6 +1018,23 @@ static void cp210x_get_termios_port(struct usb_serial_port *port,
>                ctl_hs = le32_to_cpu(flow_ctl.ulControlHandshake);
>                if (ctl_hs & CP210X_SERIAL_CTS_HANDSHAKE) {
>                                dev_dbg(dev, "%s - flow control = CRTSCTS\n", __func__);
> +                             /*
> +                             * When the port is closed, the CP210x hardware disables
> +                             * auto-RTS and RTS is deasserted but it leaves auto-CTS when
> +                             * in hardware flow control mode. This prevents new data from
> +                             * being received by the port. When re-opening the port, if
> +                             * auto-CTS is enabled on the cp210x, then auto-RTS must be
> +                             * re-enabled in the driver.
> +                             */
> +                             flow_repl = le32_to_cpu(flow_ctl.ulFlowReplace);
> +                             flow_repl &= ~CP210X_SERIAL_RTS_MASK;
> +                             flow_repl |= CP210X_SERIAL_RTS_SHIFT(CP210X_SERIAL_RTS_FLOW_CTL);
> +                             flow_ctl.ulFlowReplace = cpu_to_le32(flow_repl);
> +                             cp210x_write_reg_block(port,
> +                                                             CP210X_SET_FLOW,
> +                                                             &flow_ctl,
> +                                                             sizeof(flow_ctl));
> +
>                                cflag |= CRTSCTS;
>                } else {
>                                dev_dbg(dev, "%s - flow control = NONE\n", __func__);
> --
> 2.17.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot