linux-kernel - Re: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200624074302.GK3334@localhost>
Date:   Wed, 24 Jun 2020 09:43:02 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Phu Luu <Phu.Luu@...abs.com>
Cc:     "johan@...nel.org" <johan@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Brant Merryman <Brant.Merryman@...abs.com>,
        Richard Hendricks <Richard.Hendricks@...abs.com>
Subject: Re: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic
 throttle/unthrottle

On Wed, Jun 24, 2020 at 07:01:33AM +0000, Phu Luu wrote:
> Assign the .throttle and .unthrottle functions to be generic function
> in the driver structure to prevent data loss that can otherwise occur
> if the host does not enable USB throttling.
> 
> Signed-off-by: Phu Luu <phu.luu@...abs.com>
> Signed-off-by: Brant Merryman <brant.merryman@...abs.com>

One last form issue (besides the whitespace corrupted patch 2/2 that
Greg pointed out): The SOB tags records how a patch got into the
kernel (e.g. who forwarded it) and the first SOB should generally be the
author's.

In this case, I guess Brant is the primary author as he submitted these
patches last time around. If so, you need to manually add From line at
the beginning of the mail (i.e. before the commit message). If you use
git-format-patch, git would handle that for you.

You can also use the newish "Co-developed-by" tag to indicate joint
authorship. More details can be found in 

	Documentation/process/submitting-patches.rst

Johan