linux-kernel - Re: [PATCH 03/50] staging: mmal-vchiq: Avoid use of bool in structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <307f381cbe4976c200dbcdf0670f79a6a55bf726.camel@suse.de>
Date:   Wed, 24 Jun 2020 12:26:21 +0200
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org
Cc:     kernel-list@...pberrypi.com, laurent.pinchart@...asonboard.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devel@...verdev.osuosl.org,
        Dave Stevenson <dave.stevenson@...pberrypi.org>,
        Jacopo Mondi <jacopo@...ndi.org>
Subject: Re: [PATCH 03/50] staging: mmal-vchiq: Avoid use of bool in
 structures

On Tue, 2020-06-23 at 15:11 -0700, Joe Perches wrote:
> On Tue, 2020-06-23 at 18:41 +0200, Nicolas Saenz Julienne wrote:
> > From: Dave Stevenson <dave.stevenson@...pberrypi.org>
> > 
> > Fixes up a checkpatch error "Avoid using bool structure members
> > because of possible alignment issues".
> []
> > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> []
> > @@ -1754,7 +1754,7 @@ int vchiq_mmal_component_enable(struct
> > vchiq_mmal_instance *instance,
> >  
> >  	ret = enable_component(instance, component);
> >  	if (ret == 0)
> > -		component->enabled = true;
> > +		component->enabled = 1;
> 
> This change does not match the commit description.
> 
> Also, checkpatch does not emit a warning here.

Fair enough I'll drop it for v2.

Regards,
Nicolas


Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)