linux-kernel - Re: [PATCH] VMCI: Avoid extra check for access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Jun 2020 07:11:54 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Mike Marshall <hubcap@...ibond.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>, dvhart@...radead.org,
        sgarzare@...hat.com, Thomas Gleixner <tglx@...utronix.de>,
        Ira Weiny <ira.weiny@...el.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] VMCI: Avoid extra check for access_ok()

Hi Greg,

On Wed, May 6, 2020 at 1:40 AM Souptick Joarder <jrdr.linux@...il.com> wrote:
>
> get_user_pages_fast() is already having a check for the same. This
> double check can be removed.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>

Does this need to be marked as stable ?

> ---
>  drivers/misc/vmw_vmci/vmci_host.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_host.c b/drivers/misc/vmw_vmci/vmci_host.c
> index ce16d6b..2d8328d9 100644
> --- a/drivers/misc/vmw_vmci/vmci_host.c
> +++ b/drivers/misc/vmw_vmci/vmci_host.c
> @@ -233,8 +233,6 @@ static int vmci_host_setup_notify(struct vmci_ctx *context,
>          * about the size.
>          */
>         BUILD_BUG_ON(sizeof(bool) != sizeof(u8));
> -       if (!access_ok((void __user *)uva, sizeof(u8)))
> -               return VMCI_ERROR_GENERIC;
>
>         /*
>          * Lock physical page backing a given user VA.
> --
> 1.9.1
>