linux-kernel - Re: [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3TIFCQ.1ZGWWD0PTNQ03@crapouillou.net>
Date:   Wed, 24 Jun 2020 14:03:03 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     João "H. Spies" <jhlspies@...il.com>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] MIPS: ingenic: gcw0: Fix HP detection GPIO.

Hi João,

Le mar. 23 juin 2020 à 18:19, João H. Spies <jhlspies@...il.com> a 
écrit :
> Previously marked as active high, but is in reality active low.
> 
> Cc: stable@...r.kernel.org
> Fixes: b1bfdb660516 ("MIPS: ingenic: DTS: Update GCW0 support")
> Signed-off-by: João H. Spies <jhlspies@...il.com>

Good catch.

Tested-by: Paul Cercueil <paul@...pouillou.net>
Reviewed-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  arch/mips/boot/dts/ingenic/gcw0.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/gcw0.dts 
> b/arch/mips/boot/dts/ingenic/gcw0.dts
> index 8d22828787d8..bc72304a2440 100644
> --- a/arch/mips/boot/dts/ingenic/gcw0.dts
> +++ b/arch/mips/boot/dts/ingenic/gcw0.dts
> @@ -92,7 +92,7 @@
>  			"MIC1N", "Built-in Mic";
>  		simple-audio-card,pin-switches = "Speaker", "Headphones";
> 
> -		simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_HIGH>;
> +		simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_LOW>;
>  		simple-audio-card,aux-devs = <&speaker_amp>, <&headphones_amp>;
> 
>  		simple-audio-card,bitclock-master = <&dai_codec>;
> --
> 2.17.1
>