lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Jun 2020 15:12:55 +0200 From: Andrzej Hajda <a.hajda@...sung.com> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: Jernej Skrabec <jernej.skrabec@...l.net>, "Rafael J. Wysocki" <rafael@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>, Russell King - ARM Linux <linux@...linux.org.uk>, Neil Armstrong <narmstrong@...libre.com>, Jonas Karlman <jonas@...boo.se>, Mark Brown <broonie@...nel.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>, linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>, Marek Szyprowski <m.szyprowski@...sung.com> Subject: Re: [RESEND PATCH v5 3/5] drivers core: allow probe_err accept integer and pointer types On 24.06.2020 14:53, Andy Shevchenko wrote: > On Wed, Jun 24, 2020 at 2:41 PM Andrzej Hajda <a.hajda@...sung.com> wrote: >> Many resource acquisition functions return error value encapsulated in >> pointer instead of integer value. To simplify coding we can use macro >> which will accept both types of error. >> With this patch user can use: >> probe_err(dev, ptr, ...) >> instead of: >> probe_err(dev, PTR_ERR(ptr), ...) >> Without loosing old functionality: >> probe_err(dev, err, ...) > ... > >> + * This helper implements common pattern present in probe functions for error >> + * checking: print message if the error is not -EPROBE_DEFER and propagate it. >> + * In case of -EPROBE_DEFER it sets defer probe reason, which can be checked >> + * later by reading devices_deferred debugfs attribute. >> + * It replaces code sequence: >> + * if (err != -EPROBE_DEFER) >> + * dev_err(dev, ...); > Btw, we have now %pe. Can you consider to use it? OK, I haven't noticed it finally appeared. > >> + * return err; >> + * with >> + * return probe_err(dev, err, ...); >> + * >> + * Returns @err. >> + * >> + */ >> +#define probe_err(dev, err, args...) __probe_err(dev, (long)(err), args) > Can't we use PTR_ERR() here? Nope, I want to accept both types: int and pointer. Regards Andrzej >
Powered by blists - more mailing lists