linux-kernel - Re: [PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Jun 2020 15:12:36 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>, linux-mips@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <maz@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH v3 04/14] irqchip/davinci-aintc: Fix potential resource
 leaks

> There exists potential resource leaks in the error path, fix them.

Would you like to reconsider this change description?
https://lore.kernel.org/linux-mips/be3acb13-2963-ddf1-a867-7e30fd23a0b4@loongson.cn/
https://lkml.org/lkml/2020/6/24/498

…
> +++ b/drivers/irqchip/irq-davinci-aintc.c
…
> @@ -160,4 +160,13 @@ void __init davinci_aintc_init(const struct davinci_aintc_config *config)
>  				       irq_base + irq_off, 32);
>
>  	set_handle_irq(davinci_aintc_handle_irq);
> +
> +err_domain_remove:
…

Are you sure that you would to like to release the allocated system resources
always in this function implementation?

Otherwise, I suggest to add a return statement before the source code section
for the desired exception handling.

Regards,
Markus