linux-kernel - Re: [PATCH 15/50] staging: vchi: Unify struct shim_service and struct vchi_service

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4aa38dc0cbedd31530abf0aedbe57be22f84f88.camel@suse.de>
Date:   Wed, 24 Jun 2020 16:13:35 +0200
From:   Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        kernel-list@...pberrypi.com, linux-kernel@...r.kernel.org,
        laurent.pinchart@...asonboard.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH 15/50] staging: vchi: Unify struct shim_service and
 struct vchi_service_handle

On Wed, 2020-06-24 at 17:11 +0300, Dan Carpenter wrote:
> On Tue, Jun 23, 2020 at 06:42:01PM +0200, Nicolas Saenz Julienne wrote:
> > @@ -437,12 +432,10 @@ static void service_free(struct shim_service *service)
> >  
> >  int32_t vchi_service_open(struct vchiq_instance *instance,
> >  	struct service_creation *setup,
> > -	struct vchi_service_handle **handle)
> > +	struct vchi_service **service)
> >  {
> > -	struct shim_service *service = service_alloc(instance, setup);
> > -
> > -	*handle = (struct vchi_service_handle *)service;
> >  
> > +	*service = service_alloc(instance, setup);
> >  	if (service) {
> 
> This should be checking "*service".
> 

Of course, thanks!

Reards,
Nicolas



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)