linux-kernel - Re: [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <669d5484-b1e5-dd5c-b4e5-f3b5a8b436b4@st.com>
Date:   Wed, 24 Jun 2020 15:08:22 +0000
From:   Yannick FERTRE <yannick.fertre@...com>
To:     Angelo Ribeiro <Angelo.Ribeiro@...opsys.com>,
        Philippe CORNU <philippe.cornu@...com>,
        Benjamin GAIGNARD <benjamin.gaignard@...com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        Jose Abreu <Jose.Abreu@...opsys.com>
Subject: Re: [PATCH] drm/bridge: dw-mipi-dsi.c: remove unused header file

Hello Angelo,
thank for patch.

Reviewed-by: Yannick Fertre <yannick.fertre@...com>



On 4/3/20 3:30 PM, Angelo Ribeiro wrote:
> dw-mipi-dsi does not use any definition from drm_probe_helper.
> 
> Coverity output:
> Event unnecessary_header:
> Including .../include/drm/drm_probe_helper.h does not provide any
> needed symbols.
> 
> Cc: Gustavo Pimentel <gustavo.pimentel@...opsys.com>
> Cc: Joao Pinto <jpinto@...opsys.com>
> Cc: Jose Abreu <jose.abreu@...opsys.com>
> Signed-off-by: Angelo Ribeiro <angelo.ribeiro@...opsys.com>
> ---
>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index 024acad..582635d 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -27,7 +27,6 @@
>   #include <drm/drm_modes.h>
>   #include <drm/drm_of.h>
>   #include <drm/drm_print.h>
> -#include <drm/drm_probe_helper.h>
>   
>   #define HWVER_131			0x31333100	/* IP version 1.31 */
>   
>