linux-kernel - Re: [RFC][PATCH v5 01/51] objtool: Factor out reasons to build objtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2006241734560.24656@pobox.suse.cz>
Date:   Wed, 24 Jun 2020 17:37:13 +0200 (CEST)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Matt Helsley <mhelsley@...are.com>
cc:     linux-kernel@...r.kernel.org, Josh Poimboeuf <jpoimboe@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Julien Thierry <jthierry@...hat.com>,
        Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Subject: Re: [RFC][PATCH v5 01/51] objtool: Factor out reasons to build
 objtool

Hi,

this is a nice improvement.

> diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
> index 7770edcda3a0..aa0c6d3d2d46 100644
> --- a/tools/objtool/Makefile
> +++ b/tools/objtool/Makefile
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  include ../scripts/Makefile.include
>  include ../scripts/Makefile.arch
> +include $(OUTPUT)/../../include/config/auto.conf
>  
>  # always use the host compiler
>  ifneq ($(LLVM),)
> @@ -47,8 +48,8 @@ CFLAGS += $(if $(elfshdr),,-DLIBELF_USE_DEPRECATED)
>  
>  AWK = awk
>  
> -SUBCMD_CHECK := n
> -SUBCMD_ORC := n
> +SUBCMD_CHECK := $(CONFIG_OBJTOOL_SUBCMD_CHECK)
> +SUBCMD_ORC := $(CONFIG_OBJTOOL_SUBCMD_ORC)
>  
>  ifeq ($(SRCARCH),x86)
>  	SUBCMD_CHECK := y

I guess you can remove ifeq for x86 in this patch, right? You do it later 
in 3/51, but it seems to belong here.

Miroslav