linux-kernel - Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Jun 2020 11:29:24 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     Steev Klimaszewski <steev@...i.org>
CC:     Kyuho Choi <chlrbgh0@...il.com>, Avri Altman <Avri.Altman@....com>,
        "Rob Clark" <robdclark@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Asutosh Das <asutoshd@...eaurora.org>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Bean Huo <beanhuo@...ron.com>,
        Tomas Winkler <tomas.winkler@...el.com>,
        Colin Ian King <colin.king@...onical.com>,
        "Bart Van Assche" <bvanassche@....org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

Hi Steev,

On Wed, 2020-06-24 at 11:15 -0500, Steev Klimaszewski wrote:
> On 6/23/20 8:53 PM, Stanley Chu wrote:
> > Hi Steev,
> >
> > Please help try below simple patch to see if above WriteBooster messages
> > can be eliminated.
> >
> >
> > ---
> >  drivers/scsi/ufs/ufshcd.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> > index f173ad1bd79f..089c0785f0b3 100644
> > --- a/drivers/scsi/ufs/ufshcd.c
> > +++ b/drivers/scsi/ufs/ufshcd.c
> > @@ -6985,6 +6985,8 @@ static int ufs_get_device_desc(struct ufs_hba
> > *hba)
> >  	    dev_info->wspecversion == 0x220 ||
> >  	    (hba->dev_quirks & UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES))
> >  		ufshcd_wb_probe(hba, desc_buf);
> > +	else
> > +		hba->caps &= ~UFSHCD_CAP_WB_EN;
> >  
> >  	/*
> >  	 * ufshcd_read_string_desc returns size of the string
> 
> Hi Stanley,
> 
> That worked.
> 
> 
>  1.
>     [    0.704775] ufshcd-qcom 1d84000.ufshc: ufshcd_populate_vreg:
>     Unable to find vdd-hba-supply regulator, assuming enabled
>  2.
>     [    0.704781] ufshcd-qcom 1d84000.ufshc: ufshcd_populate_vreg:
>     Unable to find vccq-supply regulator, assuming enabled
>  3.
>     [    0.704783] ufshcd-qcom 1d84000.ufshc: ufshcd_populate_vreg:
>     Unable to find vccq2-supply regulator, assuming enabled
>  4.
>     [    0.705618] ufshcd-qcom 1d84000.ufshc: Found QC Inline Crypto
>     Engine (ICE) v3.1.75
>  5.
>     [    0.707496] scsi host0: ufshcd
>  6.
>     [    0.720415] ALSA device list:
>  7.
>     [    0.720422]   No soundcards found.
>  8.
>     [    0.734245] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
>     TX]: gear=[1, 1], lane[1, 1], pwr[SLOWAUTO_MODE, SLOWAUTO_MODE],
>     rate = 0
>  9.
>     [    0.845159] ufshcd-qcom 1d84000.ufshc: ufshcd_print_pwr_info:[RX,
>     TX]: gear=[3, 3], lane[2, 2], pwr[FAST MODE, FAST MODE], rate = 2
> 10.
>     [    0.846399] ufshcd-qcom 1d84000.ufshc:
>     ufshcd_find_max_sup_active_icc_level: Regulator capability was not
>     set, actvIccLevel=0
> 11.
>     [    0.849258] scsi 0:0:0:49488: Well-known LUN    SAMSUNG
>      KLUDG4U1EA-B0C1  0500 PQ: 0 ANSI: 6
> 12.
>     [    0.853372] scsi 0:0:0:49476: Well-known LUN    SAMSUNG
>      KLUDG4U1EA-B0C1  0500 PQ: 0 ANSI: 6
> 13.
>     [    0.855135] scsi 0:0:0:49456: Well-known LUN    SAMSUNG
>      KLUDG4U1EA-B0C1  0500 PQ: 0 ANSI: 6
> 14.
>     [    0.857050] scsi 0:0:0:0: Direct-Access     SAMSUNG
>      KLUDG4U1EA-B0C1  0500 PQ: 0 ANSI: 6
> 15.
>     [    0.858297] sd 0:0:0:0: Power-on or device reset occurred
> 16.
>     [    0.859985] scsi 0:0:0:1: Direct-Access     SAMSUNG
>      KLUDG4U1EA-B0C1  0500 PQ: 0 ANSI: 6
> 17.
>     [    0.860702] sd 0:0:0:0: [sda] 29765632 4096-byte logical blocks:
>     (122 GB/114 GiB)
> 
> (full dmesg output at https://pastebin.com/Pvfqe42P )
> 
> I guess you can throw my Tested-by on there.
> 

Thanks so much for the test!
I have re-sent the patch with your "Tested-By" tag : )

Thanks a lot,
Stanley Chu